Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HLS): Add support for REQ-VIDEO-LAYOUT #5809

Merged
merged 4 commits into from
Oct 26, 2023
Merged

feat(HLS): Add support for REQ-VIDEO-LAYOUT #5809

merged 4 commits into from
Oct 26, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 25, 2023

Also add preferredVideoLayout config

@avelad
feat(HLS): Add support for REQ-VIDEO-LAYOUT
b326120 
Also add preferredVideoLayout config
@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent labels Oct 25, 2023
@avelad avelad added this to the v4.6 milestone Oct 25, 2023
@shaka-bot
Copy link
Collaborator

shaka-bot commented Oct 25, 2023 •
edited
Loading

Incremental code coverage: 89.66%

theodab
theodab requested changes Oct 26, 2023
View reviewed changes
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
test/media/adaptation_set_criteria_unit.js
@@ -19,7 +19,12 @@ describe('AdaptationSetCriteria', () => {
});
});

const builder = new shaka.media.PreferenceBasedCriteria('en', '', 0, '');
const builder = new shaka.media.PreferenceBasedCriteria(
/* language= */ 'en',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these comments to the test. The arguments list for this function was already starting to get unwieldly.

@avelad avelad requested a review from theodab October 26, 2023 06:50
theodab
theodab requested changes Oct 26, 2023
View reviewed changes
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab October 26, 2023 07:01
@avelad avelad merged commit 81fc82b into shaka-project:main Oct 26, 2023
15 of 16 checks passed
@avelad avelad deleted the hls-video-layout branch October 26, 2023 07:26
@shaka-bot shaka-bot mentioned this pull request Oct 26, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
feat(HLS): Add support for REQ-VIDEO-LAYOUT (shaka-project#5809)
2f310ea 
Also add preferredVideoLayout config
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 25, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab